Skip to content

wsgi: always record span status code to have it available in metrics #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 2, 2025
Merged

wsgi: always record span status code to have it available in metrics #3148

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
716e3d6
remove span is_recording method
GonzaloGuasch Dec 23, 2024
080ce65
Merge branch 'main' into feature/metric_status_code_span_not_recording
GonzaloGuasch Dec 23, 2024
9252deb
update changelog
GonzaloGuasch Dec 23, 2024
4d90845
update changelog && add test
GonzaloGuasch Dec 26, 2024
adeb7e9
reformat test
GonzaloGuasch Dec 26, 2024
966142e
Merge branch 'main' into feature/metric_status_code_span_not_recording
GonzaloGuasch Dec 26, 2024
2522343
Merge branch 'main' into feature/metric_status_code_span_not_recording
lzchen Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#3111](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3111))
- `opentelemetry-instrumentation-falcon` add support version to v4
([#3086](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3086))

- `opentelemetry-instrumentation-wsgi` remove is_recording method to record status code in all metrics
([#3148](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3148))

### Fixed

Expand Down
4 changes: 0 additions & 4 deletions ...ion/opentelemetry-instrumentation-wsgi/src/opentelemetry/instrumentation/wsgi/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,11 +480,7 @@ def add_response_attributes(
"""Adds HTTP response attributes to span using the arguments
passed to a PEP3333-conforming start_response callable.
"""
if not span.is_recording():
return
status_code_str, _ = start_response_status.split(" ", 1)

status_code = 0
try:
status_code = int(status_code_str)
except ValueError:
Expand Down
Loading