Add UP and FA rules to ruff
#3155
Open
+441
−405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Dec 27, 2024
Comment on lines
+23
to
+24
| "UP", # https://docs.astral.sh/ruff/rules/#pyupgrade-up | ||
| "FA" # https://docs.astral.sh/ruff/rules/#flake8-future-annotations-fa |
Member
Author
There was a problem hiding this comment.
Those two are the additions from this PR.
github-actions
bot
assigned
alizenhom,
codeboten,
codefromthecrypt,
federicobond,
gyliu513,
karthikscale3,
lmolkova,
lzchen and
NathanielRN
Viicos
approved these changes
Dec 27, 2024
Viicos
left a comment
Viicos
left a comment
There was a problem hiding this comment.
Assuming otel does not make use of any types at runtime, this should be ok
| connect_method: typing.Callable[..., typing.Any], | ||
| args: typing.Tuple[typing.Any, typing.Any], | ||
| kwargs: typing.Dict[typing.Any, typing.Any], | ||
| args: tuple[typing.Any, typing.Any], |
There was a problem hiding this comment.
Maybe next step would be to standardize typing imports (e.g. import typing; var: typing.Any vs from typing import Any; var: Any), and also how typing_extensions should be used. I usually see two patterns:
- Unconditionally import from
typing_extensionsif it is introduced in a newer Python version. We need to make sure these imports are updated whenever a Python version is dropped. - Define a typing compat module, where new typing constructs are conditionally imported from
typingortyping_extensions. Easier to update when a Python version is dropped.
Member
Author
|
If people give me their thumbs up, I'm happy to rebase this. |
Member
Author
|
If any changelog is needed, please let me know. :) |
Kludex
force-pushed
the
enforce-future-annotations
branch
from
78526e4 to
be8ab2f
Compare
emdneto
reviewed
Jan 3, 2025
Member
emdneto
left a comment
emdneto
left a comment
There was a problem hiding this comment.
Maybe we can start using .git-blame-ignore-revs for ruff changes that touches several files
Kludex
force-pushed
the
enforce-future-annotations
branch
from
be8ab2f to
4a06c4d
Compare
emdneto
approved these changes
Jan 3, 2025
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid misunderstandings like #3118, we can enforce the
from __future__ import annotations.This PR only adds the rules and apply changes to pass the pipeline.