Skip to content

Conversation

jamestjw
Copy link

@jamestjw jamestjw commented Jan 10, 2025

Description

When getting a cursor with a name, the Connection class produces a cursor using server_cursor_factory. However, this factory isn't instrumented. This PR aims to remedy this issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I added unit tests that would fail without my changes.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Copy link

linux-foundation-easycla bot commented Jan 10, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jamestjw / name: James Tan (aa6e03e)

@github-actions github-actions bot requested a review from federicobond January 10, 2025 22:53
@jamestjw jamestjw force-pushed the fix/server-cursor-factory branch from 8cba3e6 to 5e11096 Compare January 10, 2025 22:54
@jamestjw jamestjw changed the title psycogpg: Patch server_cursor_factory psycopg: Patch server_cursor_factory Jan 10, 2025
@jamestjw jamestjw force-pushed the fix/server-cursor-factory branch 3 times, most recently from 15cab9e to 3334e74 Compare January 14, 2025 06:15
@jamestjw jamestjw force-pushed the fix/server-cursor-factory branch from 3334e74 to aa6e03e Compare April 13, 2025 05:17
pmcollins pushed a commit to pmcollins/opentelemetry-python-contrib that referenced this pull request Sep 9, 2025
* opentelemetry-sdk: clarify Resource.create usage

After open-telemetry#3181 ResourceDetector instances cannot call Resource.create
otherwise when using auto-instrumentation you'll go into an infinite loop
trying to load resource detectors.

* Update opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py

Co-authored-by: Aaron Abbott <[email protected]>

* Update opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py

Co-authored-by: Aaron Abbott <[email protected]>

* More precise instructions

---------

Co-authored-by: Aaron Abbott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants