Skip to content

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Jan 23, 2025

Description

Part of #3041, follow up to #3192

Adds Gen AI events for model input to the VertexAI instrumentation. These are system event, user event, and assistant event.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added test cases for the various log events with OTEL_INSTRUMENTATION_GENAI_CAPTURE_MESSAGE_CONTENT varied true and false.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass force-pushed the vertex-1-events branch 2 times, most recently from 208af92 to 5033da7 Compare January 23, 2025 06:17
@aabmass aabmass changed the title VertexAI emit user events VertexAI emit user, system, and assistant events Jan 23, 2025
@aabmass aabmass marked this pull request as ready for review January 23, 2025 06:22
@aabmass aabmass requested a review from a team as a code owner January 23, 2025 06:22
@aabmass aabmass enabled auto-merge (squash) January 29, 2025 22:15
@aabmass aabmass merged commit 748c925 into open-telemetry:main Jan 29, 2025
694 checks passed
@aabmass aabmass deleted the vertex-1-events branch January 29, 2025 23:48
aryabharat pushed a commit to aryabharat/opentelemetry-python-contrib that referenced this pull request Feb 2, 2025
* VertexAI emit user events

* Emit system and assistant events

* Fix for python 3.8

* Record events regardless of span recording

* fix tests

* Apply suggestions from code review

Co-authored-by: Emídio Neto <[email protected]>

---------

Co-authored-by: Emídio Neto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.