-
Notifications
You must be signed in to change notification settings - Fork 798
upgrade opentelemetry-exporter-prometheus-remote-write to use protobuf 5.26 #3219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+96
−362
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
df710aa
Allow protobuf version above 4 and under 6 for opentelemetry_exporter…
michaelschuett-tomtom ab31103
update version
michaelschuett-tomtom c2fd3a3
fix tests
michaelschuett-tomtom b6acca1
Merge branch 'main' into main
michaelschuett-tomtom 414a68f
regenerate protobufs
michaelschuett-tomtom 720e018
with newer protoc
michaelschuett-tomtom e5e2826
format
michaelschuett-tomtom 7f8b83c
actually support 5.26 protobuf
michaelschuett-tomtom 2c53a1b
changelog
michaelschuett-tomtom 7daebc7
Merge branch 'main' into main
emdneto 356efcc
Update CHANGELOG.md
michaelschuett-tomtom 6b23343
Merge branch 'main' into main
aabmass File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
exporter/opentelemetry-exporter-prometheus-remote-write/proto/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
## Instructions | ||
1. Install protobuf tools. Can use your package manager or download from [GitHub](https://github.com/protocolbuffers/protobuf/releases/tag/v21.7) | ||
2. Run `generate-proto-py.sh` from inside the `proto/` directory | ||
1. Install protobuf tools. Can use your package manager or download from [GitHub](https://github.com/protocolbuffers/protobuf/releases/tag/v26.0) | ||
2. Run `generate-proto-py.sh` from inside the `proto/` directory |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
256 changes: 10 additions & 246 deletions
256
...remote-write/src/opentelemetry/exporter/prometheus_remote_write/gen/gogoproto/gogo_pb2.py
Large diffs are not rendered by default.
Oops, something went wrong.
71 changes: 29 additions & 42 deletions
71
...metheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/gen/remote_pb2.py
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
119 changes: 50 additions & 69 deletions
119
...ometheus-remote-write/src/opentelemetry/exporter/prometheus_remote_write/gen/types_pb2.py
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.