-
Notifications
You must be signed in to change notification settings - Fork 825
Render strings in bedrock test cassettes for readability #3243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
instrumentation/opentelemetry-instrumentation-botocore/tests/conftest.py
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-botocore/tests/conftest.py
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-botocore/tests/conftest.py
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-botocore/tests/conftest.py
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-botocore/tests/conftest.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better as at least the request side is completely readable now, as is the response side non-streaming. Streaming responses use a binary format, so while the body cannot be improved, the headers are.
Good work!
...ation/opentelemetry-instrumentation-botocore/tests/cassettes/test_converse_with_content.yaml
Show resolved
Hide resolved
xrmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Description
Previously API recordings for AWS SDK Bedrock instrumentation tests were formatted as binary making them unreadable in things like code review. This formats them to
/cc @xrmx @codefromthecrypt
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.