Skip to content

botocore: sns set destination name attribute to arn and redact phone number #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 10, 2025
Merged

botocore: sns set destination name attribute to arn and redact phone number #3249

merged 10 commits into from
Mar 10, 2025

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Feb 7, 2025 •
edited
Loading 

instrumentation/opentelemetry-instrumentation-botocore/tests/test_botocore_sns.py::TestSnsExtension::test_publish_to_phone_number 
-------------------------------------------------------------------------------- live log call --------------------------------------------------------------------------------
WARNING  opentelemetry.attributes:__init__.py:100 Invalid type NoneType for attribute 'messaging.destination.name' value. Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or a sequence of those types

emdneto
emdneto commented Feb 7, 2025
View reviewed changes
@emdneto emdneto marked this pull request as ready for review February 11, 2025 14:29
@emdneto emdneto requested a review from a team as a code owner February 11, 2025 14:29
@emdneto
redact phone_number
26f2063 
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto changed the title botocore: sns set destination name attribute only if not phone number botocore: sns set destination name attribute to arn and redact phone number Feb 13, 2025
@xrmx xrmx enabled auto-merge (squash) March 10, 2025 09:32
@xrmx xrmx merged commit 3708604 into open-telemetry:main Mar 10, 2025
712 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Done in @xrmx's Python PR digest Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

@xrmx's Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emdneto @xrmx @tammy-baylis-swi