Handle empty strings in sqlcommenter #3309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safer check for a trailing semicolon that could handle empty strings as well.
xrmx
approved these changes
Feb 28, 2025
Contributor
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
LGTM, Could you please add a test case so we can avoid regressions in the future?
Contributor
Author
|
Sure thing, just added one. |
tammy-baylis-swi
approved these changes
Mar 10, 2025
Contributor
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Lgtm too, please resolve the merge conflict.
github-project-automation
bot
moved this from Reviewed PR that needs fixing
to Done
in @xrmx's Python PR digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safer check for a trailing semicolon that could handle empty strings as well.
Description
Improved trailing semicolon check that could handle empty strings as well.
Fixes #3308
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.