autoinstrumentation: catch ModuleNotFoundError when the library is not installed
#3423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt exception from bubbling up Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
emdneto
changed the title
ModuleNotFoundError when the library is not installed
xrmx
reviewed
Apr 14, 2025
opentelemetry-instrumentation/tests/auto_instrumentation/test_load.py
Outdated
Show resolved
Hide resolved
Signed-off-by: emdneto <[email protected]>
aabmass
approved these changes
Apr 14, 2025
lzchen
approved these changes
Apr 14, 2025
rjduffner
reviewed
Apr 14, 2025
rjduffner
approved these changes
Apr 14, 2025
emdneto
commented
Apr 15, 2025
xrmx
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3421
Altough ModuleNotFoundError is a subclass of ImportError, we are catching
ModuleNotFoundErrorand logging a debug message instead of an exception to keep the behaviour before #3202