- 
                Notifications
    
You must be signed in to change notification settings  - Fork 805
 
fix: respect supress_instrumentation functionality in sqlalchemy instrumentation #3477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
      
        
          +89
        
        
          −2
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    tammy-baylis-swi
  
              
              approved these changes
              
                  
                    May 8, 2025 
                  
              
              
            
            
              
                    emdneto
  
              
              approved these changes
              
                  
                    May 9, 2025 
                  
              
              
            
            
Fix changelog after release
| 
           I have updated the changelog after release. Can you re-review?  | 
    
              
                    tammy-baylis-swi
  
              
              approved these changes
              
                  
                    May 26, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
| 
           
  | 
    
              
                    emdneto
  
              
              approved these changes
              
                  
                    May 29, 2025 
                  
              
              
            
            
    
  devmonkey22 
      pushed a commit
        to devmonkey22/opentelemetry-python-contrib
      that referenced
      this pull request
    
      Aug 5, 2025 
    
    
      
  
    
      
    
  
…rumentation (open-telemetry#3477) * respect supress_instrumentation * update changelog * Update CHANGELOG.md Fix changelog after release --------- Co-authored-by: Emídio Neto <[email protected]> Co-authored-by: Riccardo Magliocchetti <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #3454
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Run this file via uv with my changes, i.e.
uv sync && uv run reproduce.pyDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.