Skip to content

opentelemetry-exporter-prometheus-remote-write: workaround build failure with Pypy 3.8 #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

opentelemetry-exporter-prometheus-remote-write: workaround build failure with Pypy 3.8 #3480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exporter/opentelemetry-exporter-prometheus-remote-write/test-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ asgiref==3.8.1
certifi==2024.7.4
charset-normalizer==3.3.2
# We can drop this after bumping baseline to pypy-39
cramjam==2.1.0; platform_python_implementation == "PyPy"
cramjam==2.8.0; platform_python_implementation == "PyPy"
cramjam==2.8.4; platform_python_implementation != "PyPy"
Deprecated==1.2.14
idna==3.7
Expand Down
5 changes: 5 additions & 0 deletions ...telemetry-exporter-prometheus-remote-write/tests/test_prometheus_remote_write_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.

import unittest
from platform import python_implementation
from unittest.mock import patch

import pytest
Expand Down Expand Up @@ -282,6 +283,10 @@ def test_invalid_tls_config_key_only_param(self):
)


@pytest.mark.skipif(
python_implementation() == "PyPy",
reason="Fails with pypy 3.8, bump cramjam when 3.9 is baseline",
)
# Ensures export is successful with valid export_records and config
@patch("requests.post")
def test_valid_export(mock_post, prom_rw, metric):
Expand Down
Loading