Skip to content

opentelemetry-instrumentation-urllib3: add explicit http duration buckets for stable semconv #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 23, 2025
Merged

opentelemetry-instrumentation-urllib3: add explicit http duration buckets for stable semconv #3518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4ba77d
opentelemetry-instrumentation-urllib3: add explicit http duration buc…
xrmx May 21, 2025
9b0c869
Add Changelog
xrmx May 21, 2025
c2232fc
Update CHANGELOG.md
xrmx May 21, 2025
1b11d29
Merge branch 'main' into proper-buckets-http-stable-urllib3
emdneto May 21, 2025
aa5c64c
Merge branch 'main' into proper-buckets-http-stable-urllib3
xrmx May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- `opentelemetry-instrumentation-fastapi`: fix wrapping of middlewares
([#3012](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3012))
- `opentelemetry-instrumentation-urllib3`: proper bucket boundaries in stable semconv http duration metrics
([#3518](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3518))
- `opentelemetry-instrumentation-urllib`: proper bucket boundaries in stable semconv http duration metrics
([#3519](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3519))
- `opentelemetry-instrumentation-falcon`: proper bucket boundaries in stable semconv http duration
Expand Down
2 changes: 2 additions & 0 deletions ...entelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ def response_hook(
import wrapt

from opentelemetry.instrumentation._semconv import (
HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
_client_duration_attrs_new,
_client_duration_attrs_old,
_filter_semconv_duration_attrs,
Expand Down Expand Up @@ -267,6 +268,7 @@ def _instrument(self, **kwargs):
name=HTTP_CLIENT_REQUEST_DURATION,
unit="s",
description="Duration of HTTP client requests.",
explicit_bucket_boundaries_advisory=HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
)
# http.client.request.body.size histogram
request_size_histogram_new = create_http_client_request_body_size(
Expand Down
4 changes: 4 additions & 0 deletions instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from urllib3 import encode_multipart_formdata

from opentelemetry.instrumentation._semconv import (
HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
OTEL_SEMCONV_STABILITY_OPT_IN,
_OpenTelemetrySemanticConventionStability,
)
Expand Down Expand Up @@ -169,6 +170,7 @@ def test_basic_metrics_new_semconv(self):
max_data_point=duration_s,
min_data_point=duration_s,
attributes=attrs_new,
explicit_bounds=HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
)
],
est_value_delta=40 / 1000,
Expand Down Expand Up @@ -258,6 +260,7 @@ def test_basic_metrics_both_semconv(self):
max_data_point=duration_s,
min_data_point=duration_s,
attributes=attrs_new,
explicit_bounds=HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
)
],
est_value_delta=40 / 1000,
Expand Down Expand Up @@ -451,6 +454,7 @@ def test_basic_metrics_nonstandard_http_method_new_semconv(self):
max_data_point=duration_s,
min_data_point=duration_s,
attributes=attrs_new,
explicit_bounds=HTTP_DURATION_HISTOGRAM_BUCKETS_NEW,
)
],
est_value_delta=40 / 1000,
Expand Down