Skip to content

Conversation

@artemziborev
Copy link
Contributor

@artemziborev artemziborev commented May 23, 2025

Description

This PR replaces deprecated usage of SpanAttributes with semantic convention attributes from opentelemetry.semconv.attributes in the opentelemetry-instrumentation-flask package.

These changes bring the Flask instrumentation module in line with current OpenTelemetry conventions and help modernize the codebase as part of the broader refactoring tracked in the issue below.

Refs #3475

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran pytest for instrumentation/opentelemetry-instrumentation-flask/tests/
  • Verified that no references to SpanAttributes remain
  • Confirmed proper attribute output using updated semconv references

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • [X ] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Unit tests pass for this module

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 23, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@artemziborev
Copy link
Contributor Author

Hi 👋 Just wanted to kindly follow up.

This PR replaces deprecated SpanAttributes usage in the Flask instrumentation with the recommended semantic convention attributes (http.method, http.route, etc.), as described in #3475.

All changes were tested locally and verified against the existing test suite. Please let me know if anything should be adjusted or improved — happy to iterate!

Thanks for your time and for maintaining this project 🙏

@xrmx xrmx moved this to Easy to review / merge / close in @xrmx's Python PR digest May 23, 2025
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 23, 2025
@xrmx xrmx moved this from Easy to review / merge / close to Reviewed PR that needs fixing in @xrmx's Python PR digest May 27, 2025
@xrmx xrmx self-requested a review May 27, 2025 20:20
@artemziborev
Copy link
Contributor Author

Hi! All checks have passed — would love to get a review when you have a moment. Let me know if any changes are needed 🙌

@xrmx xrmx moved this from Reviewed PR that needs fixing to Easy to review / merge / close in @xrmx's Python PR digest Sep 10, 2025
@xrmx xrmx enabled auto-merge (squash) September 10, 2025 12:18
@xrmx xrmx merged commit 6c2aa7f into open-telemetry:main Sep 10, 2025
632 checks passed
@github-project-automation github-project-automation bot moved this from Easy to review / merge / close to Done in @xrmx's Python PR digest Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants