-
Notifications
You must be signed in to change notification settings - Fork 800
refactor(flask): replace SpanAttributes with semconv attributes #3539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(flask): replace SpanAttributes with semconv attributes #3539
Conversation
|
Hi 👋 Just wanted to kindly follow up. This PR replaces deprecated All changes were tested locally and verified against the existing test suite. Please let me know if anything should be adjusted or improved — happy to iterate! Thanks for your time and for maintaining this project 🙏 |
…nto refactor-flask-spanattributes
...tion/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
Show resolved
Hide resolved
|
Hi! All checks have passed — would love to get a review when you have a moment. Let me know if any changes are needed 🙌 |
Description
This PR replaces deprecated usage of
SpanAttributeswith semantic convention attributes fromopentelemetry.semconv.attributesin theopentelemetry-instrumentation-flaskpackage.These changes bring the Flask instrumentation module in line with current OpenTelemetry conventions and help modernize the codebase as part of the broader refactoring tracked in the issue below.
Refs #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
pytestforinstrumentation/opentelemetry-instrumentation-flask/tests/SpanAttributesremainDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.