Fix to properly skip all tornado server telemetry when URL excluded

[devmonkey22]

Description

Updated the tornado instrumentation to keep track of if the current handler is executing an excluded URL. If so, it skips tracking metrics both for request/responses.

• Fixes Tornado instrumentation collecting partial/incorrect telemetry when URL excluded #3677
• Includes changes from Fix tornado server (request) duration metric calculation #3679 due to needing same handler state object.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Added TestTornadoMetricsInstrumentation.test_exclude_lists test to verify metrics written don't include server metrics anymore when fetching an excluded URL.

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[tammy-baylis-swi]

Thanks for this one as well!

It looks like this PR includes the changes from #3679. Could we keep the changes separate?

[devmonkey22]

Thanks for this one as well!

It looks like this PR includes the changes from #3679. Could we keep the changes separate?

@tammy-baylis-swi I need the code changes from #3679 in order to have a place to store the exclude_url flag in state (that's async-safe still). Is there a preferred way to include those changes? Or do you just want me to copy the code from init.py without the actual commits, then deal with the merge conflicts (if not auto-mergeable) later, depending on which PR merges first?

[tammy-baylis-swi]

@tammy-baylis-swi I need the code changes from #3679 in order to have a place to store the exclude_url flag in state (that's async-safe still). Is there a preferred way to include those changes? Or do you just want me to copy the code from init.py without the actual commits, then deal with the merge conflicts (if not auto-mergeable) later, depending on which PR merges first?

Ah all right, and it is mentioned in the description.

There's no one preferred way. I'd suggest adjusting the description of #3679 to make it clear that it's introducing a new handler state object. Then maybe #3679 should be the one merged first, and this one after. I'll take a look at the other one for now.