botocore: Add support for SNS semantic convention attribute aws.sns.topic.arn #3734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opic.arn The AWS SNS semantic convention defines the attribute aws.sns.topic.arn: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/registry/attributes/aws.md#amazon-sns-attributes Currently, this attribute is not set in the botocore instrumentation library. This PR adds support for it by setting the attribute from both the request and response objects. Tests New unit tests added and passing. Verified with: tox -e py312-test-instrumentation-botocore tox -e spellcheck tox -e lint-instrumentation-botocore tox -e ruff Backward Compatibility There is no risk of breaking existing functionality. This change only adds instrumentation for an additional AWS resource without modifying the existing behavior of the auto-instrumentation library.
tammy-baylis-swi
approved these changes
Sep 5, 2025
xrmx
reviewed
Sep 9, 2025
...emetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/sns.py
Show resolved
Hide resolved
xrmx
approved these changes
Sep 9, 2025
github-project-automation
bot
moved this from Ready for review
to Done
in @xrmx's Python PR digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The AWS SNS semantic convention defines the attribute aws.sns.topic.arn: https://github.com/open-telemetry/semantic-conventions/blob/main/docs/registry/attributes/aws.md#amazon-sns-attributes
Currently, this attribute is not set in the botocore instrumentation library.
Fixes # (issue)
This PR adds support for it by setting the attribute from both the request and response objects.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
New unit tests added and passing.
Verified with:
tox -e py312-test-instrumentation-botocore
tox -e spellcheck
tox -e lint-instrumentation-botocore
tox -e ruff
Backward Compatibility
There is no risk of breaking existing functionality. This change only adds instrumentation for an additional AWS resource without modifying the existing behavior of the auto-instrumentation library.
Does This PR Require a Core Repo Change?