-
Notifications
You must be signed in to change notification settings - Fork 798
Define genai content uploader hook and entry point #3752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload_hook.py
Show resolved
Hide resolved
util/opentelemetry-util-genai/src/opentelemetry/util/genai/__init__.py
Outdated
Show resolved
Hide resolved
DylanRussell
approved these changes
Sep 12, 2025
230efe0
to
01cf2d9
Compare
xrmx
reviewed
Sep 15, 2025
01cf2d9
to
0ad6621
Compare
aabmass
commented
Sep 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reviews. I tweaked this a little to expect the entrypoint to return a UploadHook
class instance which has an upload()
method.
0ad6621
to
d7bd1a1
Compare
LGTM |
This was referenced Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces an interface for the generic GenAI upload hook. See SemConv uploading content to external storage. It also adds an entry point and environment variable to load an upload hook.
Instrumentations should load the hook with
load_upload_hook()
and call it before ending the span as described in semconv.The upload hook implementor is responsible for implementing batching and backpressure if they choose to do so.
Part of #3065, #3753
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.