-
Notifications
You must be signed in to change notification settings - Fork 783
GenAI Utils | Inference Type and Span Creation #3768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keith-decker
wants to merge
29
commits into
open-telemetry:main
Choose a base branch
from
zhirafovod:util-genai-inference-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+631
−13
Open
Changes from 13 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
73a764c
cherry pick changes from previous PR
keith-decker 0d749a9
move span utils to new file
keith-decker 77d9c3c
remove span state, use otel context for parent/child
keith-decker 054ebe9
flatten LLMInvocation to use attributes instead of dict keys
keith-decker 9d3926f
helper function and docstrings
keith-decker 635b7f8
Merge branch 'main' into util-genai-inference-clean
keith-decker 9837cf4
refactor: store span and context token in LLMInvocation instead of Sp…
keith-decker 1a172d1
refactor: rename prompts/chat_generations to input_messages/output_me…
keith-decker 465ca78
refactor: simplify TelemetryHandler API by moving invocation data man…
keith-decker cd5aaa6
refactor: update relative imports to absolute imports
keith-decker 8347d17
Update handler to use a context manager instead of start_llm and stop…
keith-decker 742a36f
resolve tox -e doc failure
keith-decker 00e08a8
safeguard against empty request-model
keith-decker 109625c
Merge branch 'main' into util-genai-inference-clean
keith-decker 80c94bf
fix tox typecheck errors for utils
keith-decker f07c61f
refactor: move tracer to generator, clean up dead code
keith-decker d6f722f
remove unused linting hint
keith-decker fdc7f50
back off stricter request-model requirements
keith-decker da20448
reintroduce manual start/stop for langchain callback flow
keith-decker c1ff846
Merge branch 'main' into util-genai-inference-clean
aabmass 4a08d7f
clean up context handler, clarify unit tests
keith-decker 243bf8d
remove generator concept
keith-decker 3d6c8da
Merge branch 'main' into util-genai-inference-clean
keith-decker 5f8cd1c
update token types
keith-decker e987d66
Merge branch 'main' into util-genai-inference-clean
keith-decker 51d28c0
code cleanup
keith-decker 88d0149
Merge branch 'main' into util-genai-inference-clean
keith-decker 188e84b
Merge branch 'main' into util-genai-inference-clean
keith-decker c264c46
Merge branch 'main' into util-genai-inference-clean
keith-decker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ dynamic = ["version"] | |
description = "OpenTelemetry GenAI Utils" | ||
readme = "README.rst" | ||
license = "Apache-2.0" | ||
requires-python = ">=3.8" | ||
requires-python = ">=3.9" | ||
authors = [ | ||
{ name = "OpenTelemetry Authors", email = "[email protected]" }, | ||
] | ||
|
@@ -25,8 +25,8 @@ classifiers = [ | |
"Programming Language :: Python :: 3.13", | ||
] | ||
dependencies = [ | ||
"opentelemetry-instrumentation ~= 0.51b0", | ||
"opentelemetry-semantic-conventions ~= 0.51b0", | ||
"opentelemetry-instrumentation ~= 0.57b0", | ||
"opentelemetry-semantic-conventions ~= 0.57b0", | ||
"opentelemetry-api>=1.31.0", | ||
] | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Copyright The OpenTelemetry Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. |
120 changes: 120 additions & 0 deletions
120
util/opentelemetry-util-genai/src/opentelemetry/util/genai/generators.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,120 @@ | ||
# Copyright The OpenTelemetry Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
""" | ||
Span generation utilities for GenAI telemetry. | ||
|
||
This module maps GenAI (Generative AI) invocations to OpenTelemetry spans and | ||
applies GenAI semantic convention attributes. | ||
|
||
Classes: | ||
- BaseTelemetryGenerator: Abstract base for GenAI telemetry emitters. | ||
- SpanGenerator: Concrete implementation that creates and finalizes spans | ||
for LLM operations (e.g., chat) and records input/output messages when | ||
experimental mode and content capture settings allow. | ||
|
||
Usage: | ||
See `opentelemetry/util/genai/handler.py` for `TelemetryHandler`, which | ||
constructs `LLMInvocation` objects and delegates to `SpanGenerator.start`, | ||
`SpanGenerator.finish`, and `SpanGenerator.error` to produce spans that | ||
follow the GenAI semantic conventions. | ||
""" | ||
|
||
from contextvars import Token | ||
from typing import Dict, Optional | ||
from uuid import UUID | ||
|
||
from typing_extensions import TypeAlias | ||
|
||
from opentelemetry import context as otel_context | ||
from opentelemetry import trace | ||
from opentelemetry.semconv._incubating.attributes import ( | ||
gen_ai_attributes as GenAI, | ||
) | ||
from opentelemetry.trace import ( | ||
Span, | ||
SpanKind, | ||
Tracer, | ||
set_span_in_context, | ||
) | ||
from opentelemetry.util.genai.span_utils import ( | ||
_apply_error_attributes, | ||
_apply_finish_attributes, | ||
) | ||
from opentelemetry.util.genai.types import Error, LLMInvocation | ||
|
||
# Type alias matching the token type expected by opentelemetry.context.detach | ||
ContextToken: TypeAlias = Token[otel_context.Context] | ||
|
||
|
||
class BaseTelemetryGenerator: | ||
""" | ||
Abstract base for emitters mapping GenAI types -> OpenTelemetry. | ||
""" | ||
|
||
def start(self, invocation: LLMInvocation) -> None: | ||
raise NotImplementedError | ||
|
||
def finish(self, invocation: LLMInvocation) -> None: | ||
raise NotImplementedError | ||
|
||
def error(self, error: Error, invocation: LLMInvocation) -> None: | ||
raise NotImplementedError | ||
|
||
|
||
class SpanGenerator(BaseTelemetryGenerator): | ||
keith-decker marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
""" | ||
Generates only spans. | ||
""" | ||
|
||
def __init__( | ||
self, | ||
tracer: Optional[Tracer] = None, | ||
): | ||
self._tracer: Tracer = tracer or trace.get_tracer(__name__) | ||
|
||
# Store the active span and its context attachment token | ||
self._active: Dict[UUID, tuple[Span, ContextToken]] = {} | ||
pmcollins marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
def start(self, invocation: LLMInvocation): | ||
# Create a span and attach it as current; keep the token to detach later | ||
if not (invocation.request_model and invocation.request_model.strip()): | ||
raise ValueError("request_model is required") | ||
span = self._tracer.start_span( | ||
name=f"{GenAI.GenAiOperationNameValues.CHAT.value} {invocation.request_model}", | ||
DylanRussell marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
kind=SpanKind.CLIENT, | ||
) | ||
invocation.span = span | ||
invocation.context_token = otel_context.attach( | ||
set_span_in_context(span) | ||
) | ||
|
||
def finish(self, invocation: LLMInvocation): | ||
if invocation.context_token is None or invocation.span is None: | ||
return | ||
|
||
_apply_finish_attributes(invocation.span, invocation) | ||
# Detach context and end span | ||
otel_context.detach(invocation.context_token) | ||
invocation.span.end() | ||
|
||
def error(self, error: Error, invocation: LLMInvocation): | ||
if invocation.context_token is None or invocation.span is None: | ||
return | ||
|
||
_apply_error_attributes(invocation.span, error) | ||
# Detach context and end span | ||
otel_context.detach(invocation.context_token) | ||
invocation.span.end() | ||
return |
114 changes: 114 additions & 0 deletions
114
util/opentelemetry-util-genai/src/opentelemetry/util/genai/handler.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,114 @@ | ||
# Copyright The OpenTelemetry Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
""" | ||
Telemetry handler for GenAI invocations. | ||
|
||
This module exposes the `TelemetryHandler` class, which manages the lifecycle of | ||
GenAI (Generative AI) invocations and emits telemetry data (spans and related attributes). | ||
It supports starting, stopping, and failing LLM invocations. | ||
|
||
Classes: | ||
- TelemetryHandler: Manages GenAI invocation lifecycles and emits telemetry. | ||
|
||
Functions: | ||
- get_telemetry_handler: Returns a singleton `TelemetryHandler` instance. | ||
|
||
Usage: | ||
handler = get_telemetry_handler() | ||
|
||
# Create an invocation object with your request data | ||
# The span and context_token attributes are set by the TelemetryHandler, and | ||
# managed by the TelemetryHandler during the lifecycle of the span. | ||
invocation = LLMInvocation( | ||
request_model="my-model", | ||
input_messages=[...], | ||
provider="my-provider", | ||
attributes={"custom": "attr"}, | ||
) | ||
|
||
# Start the invocation (opens a span) | ||
handler.start_llm(invocation) | ||
|
||
# Populate outputs and any additional attributes, then stop (closes the span) | ||
invocation.output_messages = [...] | ||
invocation.attributes.update({"more": "attrs"}) | ||
handler.stop_llm(invocation) | ||
|
||
# Or, in case of error | ||
# handler.fail_llm(invocation, Error(type="...", message="...")) | ||
""" | ||
|
||
import time | ||
from contextlib import contextmanager | ||
from typing import Any, Iterator, Optional | ||
|
||
from opentelemetry.semconv.schemas import Schemas | ||
from opentelemetry.trace import get_tracer | ||
from opentelemetry.util.genai.generators import SpanGenerator | ||
from opentelemetry.util.genai.types import Error, LLMInvocation | ||
from opentelemetry.util.genai.version import __version__ | ||
|
||
|
||
class TelemetryHandler: | ||
DylanRussell marked this conversation as resolved.
Show resolved
Hide resolved
|
||
""" | ||
High-level handler managing GenAI invocation lifecycles and emitting | ||
them as spans, metrics, and events. | ||
""" | ||
|
||
def __init__(self, **kwargs: Any): | ||
tracer_provider = kwargs.get("tracer_provider") | ||
self._tracer = get_tracer( | ||
__name__, | ||
__version__, | ||
tracer_provider, | ||
schema_url=Schemas.V1_36_0.value, | ||
) | ||
|
||
self._generator = SpanGenerator(tracer=self._tracer) | ||
pmcollins marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
@contextmanager | ||
def llm(self, invocation: LLMInvocation) -> Iterator[LLMInvocation]: | ||
"""Context manager for LLM invocations. | ||
|
||
Only set data attributes on the invocation object, do not modify the span or context. | ||
|
||
Starts the span on entry. On normal exit, finalizes the invocation and ends the span. | ||
If an exception occurs inside the context, marks the span as error, ends it, and | ||
re-raises the original exception. | ||
""" | ||
self._generator.start(invocation) | ||
try: | ||
yield invocation | ||
except BaseException as exc: # noqa: B902 - ensure we capture all exceptions incl. SystemExit, KeyboardInterrupt | ||
DylanRussell marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
invocation.end_time = time.time() | ||
self._generator.error( | ||
Error(message=str(exc), type=type(exc)), invocation | ||
) | ||
raise | ||
invocation.end_time = time.time() | ||
self._generator.finish(invocation) | ||
|
||
|
||
def get_telemetry_handler(**kwargs: Any) -> TelemetryHandler: | ||
""" | ||
Returns a singleton TelemetryHandler instance. | ||
""" | ||
handler: Optional[TelemetryHandler] = getattr( | ||
get_telemetry_handler, "_default_handler", None | ||
) | ||
if handler is None: | ||
handler = TelemetryHandler(**kwargs) | ||
setattr(get_telemetry_handler, "_default_handler", handler) | ||
return handler |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.