Skip to content

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Sep 19, 2025

Description

Fixes #3767

  • Fix some places the semaphore could be missed
  • Fix flakes from Mock.call_count not being thread safe
  • Added shutdown timeout implementation

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I ran the tests repeating 1000s of times with pypy and verified no more flakes ❄️

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@aabmass aabmass added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 19, 2025
@aabmass aabmass requested a review from a team as a code owner September 19, 2025 03:01
@aabmass aabmass added the gen-ai Related to generative AI label Sep 19, 2025
@aabmass aabmass force-pushed the fsspec-flaky-bugs branch 2 times, most recently from f0b745e to 3c80b06 Compare September 19, 2025 04:27
@aabmass
Copy link
Member Author

aabmass commented Sep 19, 2025

I saw it flake one more time, but can't reproduce it locally. I added one more fix and seems to be ok now after a few re-runs

@aabmass
Copy link
Member Author

aabmass commented Sep 19, 2025

Ya seems to be good now
image

Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for screenshots too

@aabmass aabmass enabled auto-merge (squash) September 19, 2025 19:14
@aabmass aabmass merged commit 13fa314 into open-telemetry:main Sep 19, 2025
632 checks passed
@aabmass aabmass deleted the fsspec-flaky-bugs branch September 19, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gen-ai Related to generative AI Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky tests with pypy 3.9

3 participants