Skip to content

Replace SpanAttributes by semconv._incubating.attributes #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
+16 −16
Merged

Replace SpanAttributes by semconv._incubating.attributes #3809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions ...ation/opentelemetry-instrumentation-redis/src/opentelemetry/instrumentation/redis/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,18 @@

from typing import TYPE_CHECKING, Any

from opentelemetry.semconv._incubating.attributes.db_attributes import (
DB_REDIS_DATABASE_INDEX,
DB_SYSTEM,
)
from opentelemetry.semconv._incubating.attributes.net_attributes import (
NET_PEER_NAME,
NET_PEER_PORT,
NET_TRANSPORT,
)
from opentelemetry.semconv.trace import (
DbSystemValues,
NetTransportValues,
SpanAttributes,
)
from opentelemetry.trace import Span

Expand All @@ -41,25 +49,17 @@
def _extract_conn_attributes(conn_kwargs):
"""Transform redis conn info into dict"""
attributes = {
SpanAttributes.DB_SYSTEM: DbSystemValues.REDIS.value,
DB_SYSTEM: DbSystemValues.REDIS.value,
}
db = conn_kwargs.get("db", 0)
attributes[SpanAttributes.DB_REDIS_DATABASE_INDEX] = db
attributes[DB_REDIS_DATABASE_INDEX] = db
if "path" in conn_kwargs:
attributes[SpanAttributes.NET_PEER_NAME] = conn_kwargs.get("path", "")
attributes[SpanAttributes.NET_TRANSPORT] = (
NetTransportValues.OTHER.value
)
attributes[NET_PEER_NAME] = conn_kwargs.get("path", "")
attributes[NET_TRANSPORT] = NetTransportValues.OTHER.value
else:
attributes[SpanAttributes.NET_PEER_NAME] = conn_kwargs.get(
"host", "localhost"
)
attributes[SpanAttributes.NET_PEER_PORT] = conn_kwargs.get(
"port", 6379
)
attributes[SpanAttributes.NET_TRANSPORT] = (
NetTransportValues.IP_TCP.value
)
attributes[NET_PEER_NAME] = conn_kwargs.get("host", "localhost")
attributes[NET_PEER_PORT] = conn_kwargs.get("port", 6379)
attributes[NET_TRANSPORT] = NetTransportValues.IP_TCP.value

return attributes

Expand Down
Loading