Use an sha 256 hash of the system instructions as it's upload filename #3814
+147
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etry-python-contrib into hash_sys_instruct
aabmass
reviewed
Oct 7, 2025
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py
Outdated
Show resolved
Hide resolved
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py
Outdated
Show resolved
Hide resolved
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Oct 8, 2025
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py
Outdated
Show resolved
Hide resolved
DylanRussell
changed the title
aabmass
reviewed
Oct 13, 2025
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py
Show resolved
Hide resolved
util/opentelemetry-util-genai/src/opentelemetry/util/genai/_upload/completion_hook.py
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-google-genai/CHANGELOG.md
Show resolved
Hide resolved
…etry-python-contrib into hash_sys_instruct
aabmass
approved these changes
Oct 14, 2025
aabmass
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use an md5 hash of the system instructions as it's upload filename, and check if the file exists before re-uploading it..
In many (most?) cases system instructions will be text and is unlikely to change, this prevents uploading the same system instructions twice.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.