grpc: allow the user to cancel stream v2 #3823
Open
+109
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set_attribute and also set_status are not called if span was already ended. Simple reorder of function calls helped - I also realized that accessing end_time is dangerous, in SDK it is protected by lock. I solved this by remembering if we already called end. Calling multiple times end on span is not problematic, but it generates warning logs and is probably not good practice - updated CHANGELOG.md - fix lint
This reverts commit 5b26e33
This reverts commit d0abacf
aidandj
force-pushed
the
aidan/allow-the-user-to-cancel-stream-v2
branch
from
17c89a7 to
6ed2e7d
Compare
aidandj
force-pushed
the
aidan/allow-the-user-to-cancel-stream-v2
branch
from
6ed2e7d to
9bdf76a
Compare
xrmx
changed the title
xrmx
reviewed
Oct 10, 2025
...ntation/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_client.py
Show resolved
Hide resolved
xrmx
moved this from Ready for review
to Reviewed PRs that need fixes
in @xrmx's Python PR digest
xrmx
moved this from Reviewed PRs that need fixes
to Ready for review
in @xrmx's Python PR digest
Signed-off-by: Aidan Jensen <[email protected]>
aidandj
force-pushed
the
aidan/allow-the-user-to-cancel-stream-v2
branch
from
b6cf2e3 to
979f0c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An updated version of this PR: #2093
Fixes # (issue)
#2014
Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.