Skip to content

Commit fd382c9

Browse files
committed
More trivial typing for sdk
1 parent 1d62571 commit fd382c9

File tree

1 file changed

+5
-1
lines changed
  • opentelemetry-sdk/src/opentelemetry/sdk/trace

1 file changed

+5
-1
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ def on_start(
112112
span: The :class:`opentelemetry.trace.Span` that just started.
113113
parent_context: The parent context of the span that just started.
114114
"""
115+
...
115116

116117
def on_end(self, span: "ReadableSpan") -> None:
117118
"""Called when a :class:`opentelemetry.trace.Span` is ended.
@@ -122,9 +123,11 @@ def on_end(self, span: "ReadableSpan") -> None:
122123
Args:
123124
span: The :class:`opentelemetry.trace.Span` that just ended.
124125
"""
126+
...
125127

126128
def shutdown(self) -> None:
127129
"""Called when a :class:`opentelemetry.sdk.trace.TracerProvider` is shutdown."""
130+
...
128131

129132
def force_flush(self, timeout_millis: int = 30000) -> bool:
130133
"""Export all ended spans to the configured Exporter that have not yet
@@ -137,6 +140,7 @@ def force_flush(self, timeout_millis: int = 30000) -> bool:
137140
Returns:
138141
False if the timeout is exceeded, True otherwise.
139142
"""
143+
...
140144

141145

142146
# Temporary fix until https://github.com/PyCQA/pylint/issues/4098 is resolved
@@ -273,7 +277,7 @@ def force_flush(self, timeout_millis: int = 30000) -> bool:
273277
timeout, False otherwise.
274278
"""
275279
futures = []
276-
for sp in self._span_processors: # type: SpanProcessor
280+
for sp in self._span_processors:
277281
future = self._executor.submit(sp.force_flush, timeout_millis)
278282
futures.append(future)
279283

0 commit comments

Comments
 (0)