Skip to content

Conversation

@emdneto
Copy link
Member

@emdneto emdneto commented Nov 21, 2024

This PR basically shifts from depending on generating workflows every time we change something in contrib to looking to contrib@main and reusing the workflow core_contrib_test.yml. With that, we only need to update contrib workflows, and there's no need to sync workflows in core anymore.

Related PR in contrib: open-telemetry/opentelemetry-python-contrib#3035

Part of #4263

Signed-off-by: emdneto <[email protected]>
@emdneto emdneto requested a review from a team as a code owner November 21, 2024 00:53
@emdneto emdneto marked this pull request as draft November 21, 2024 00:53
Signed-off-by: emdneto <[email protected]>
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto closed this Nov 21, 2024
@emdneto emdneto reopened this Nov 21, 2024
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 21, 2024
@emdneto emdneto closed this Nov 21, 2024
@emdneto emdneto reopened this Nov 21, 2024
@emdneto emdneto marked this pull request as ready for review November 21, 2024 01:35
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto changed the title test call worflow infra: remove generate contrib workflows from core Nov 21, 2024
Copy link
Member Author

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is the first step of a major change we want to do that is related to have generate_workflows_lib for each repo instead of core depends on generate_workflos_lib hosted in contrib

@emdneto emdneto marked this pull request as draft November 25, 2024 11:07
@emdneto emdneto marked this pull request as ready for review November 26, 2024 00:55
@xrmx xrmx enabled auto-merge (squash) November 26, 2024 12:17
@emdneto emdneto disabled auto-merge November 26, 2024 13:07
@xrmx xrmx closed this Nov 26, 2024
@xrmx xrmx reopened this Nov 26, 2024
@xrmx
Copy link
Contributor

xrmx commented Nov 26, 2024

So in order to get this in it requires to update our branch protecting rules that are referencing the old jobs.

@xrmx xrmx merged commit 78653ef into open-telemetry:main Nov 26, 2024
353 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants