-
Notifications
You must be signed in to change notification settings - Fork 731
Add credentials environment variables to let ChannelCredentials
and Session
be injected
#4689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DylanRussell
wants to merge
17
commits into
open-telemetry:main
Choose a base branch
from
DylanRussell:add_cred_envvar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+314
−12
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1e68c3c
Initial Commit
DylanRussell 06dee51
Fix broken tests
DylanRussell c500b15
Start writing test
DylanRussell a6dcd1c
Fix tests
DylanRussell 5ef26f2
Merge branch 'main' of github.com:DylanRussell/opentelemetry-python i…
DylanRussell 2e76e59
Add changelog
DylanRussell 9344ebd
Improne and fix _init_exporter func
DylanRussell cc89293
Fix desc
DylanRussell f27856f
Run precommit and update variable
DylanRussell 82d72bb
Update changelog
DylanRussell 2244d5a
Merge branch 'main' into add_cred_envvar
DylanRussell afaf88d
Merge remote-tracking branch 'origin' into add_cred_envvar
DylanRussell 4881780
Fix_type
DylanRussell 66fb14d
Commit changes
DylanRussell fcadee2
Add test
DylanRussell 6c2740a
fix envvar and typecheck
DylanRussell 0dc2861
Precommit and constraints
DylanRussell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts @lzchen @xrmx @emdneto on moving the entry point loading into the actual respective exporters to avoid the defensive import checks? I don't think we've done it anywhere else, but IMO would clean up the conditional checks here and keep the SDK and exporter impls decoupled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better altough we are doing this kind of defensive import for psutil in SDK for resources