Skip to content

Feature: Include trace flags in spans exported by the OTLPSpanExporter #4761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Feature: Include trace flags in spans exported by the OTLPSpanExporter #4761

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
a1d43e8
chore: added full trace flags implementation and tests
nikhilmantri0902 Oct 2, 2025
acc6f2e
chore: added changelog entry
nikhilmantri0902 Oct 2, 2025
27a12dc
chore: removed getattr method and unnecessay int typecasts
nikhilmantri0902 Oct 3, 2025
f6e8ef1
Merge branch 'main' into feat/otlpspanexporter_traceflags_bits07
nikhilmantri0902 Oct 3, 2025
858e16b
chore: minor updates as per review
nikhilmantri0902 Oct 11, 2025
92a8960
Merge branch 'main' into feat/otlpspanexporter_traceflags_bits07
xrmx Oct 14, 2025
142ba3a
fix: tox lint errors
nikhilmantri0902 Oct 15, 2025
37312bf
fix: pylint error
nikhilmantri0902 Oct 15, 2025
55e7a3a
fix: added fixes for the failing test cases
nikhilmantri0902 Oct 19, 2025
ec02a22
fix:merged main
nikhilmantri0902 Oct 19, 2025
fb5aec8
fix: precommit formatting
nikhilmantri0902 Oct 22, 2025
0696540
Merge branch 'main' into feat/otlpspanexporter_traceflags_bits07
xrmx Oct 30, 2025
3be6a7b
Update CHANGELOG.md
xrmx Oct 30, 2025
9e581fb
Merge branch 'main' into feat/otlpspanexporter_traceflags_bits07
xrmx Oct 30, 2025
04be919
Merge branch 'main' into feat/otlpspanexporter_traceflags_bits07
xrmx Oct 31, 2025
c7a1222
fix: PR comments
nikhilmantri0902 Nov 2, 2025
01afe45
fix: failing workflow
nikhilmantri0902 Nov 3, 2025
f5eb8de
Merge branch 'main' into feat/otlpspanexporter_traceflags_bits07
xrmx Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions exporter/opentelemetry-exporter-otlp-proto-common/tests/test_trace_encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,11 +520,11 @@ def test_span_flags_root_unsampled(self):
)
span = SDKSpan(name="root", context=span_context, parent=None)
pb = _encode_span(span)
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK) == 0x00
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK) == 0x00 # pylint: disable=no-member
Copy link
Contributor

@xrmx xrmx Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this per testcase instead so we can have this only once, i.e. put this comment in first line of this class?

assert (
pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK
pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK # pylint: disable=no-member
) != 0
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK) == 0
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK) == 0 # pylint: disable=no-member
assert (pb.flags & ~ALL_SPAN_FLAGS_MASK) == 0

def test_span_flags_root_sampled(self):
Expand All @@ -533,11 +533,11 @@ def test_span_flags_root_sampled(self):
)
span = SDKSpan(name="root", context=span_context, parent=None)
pb = _encode_span(span)
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK) == 0x01
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK) == 0x01 # pylint: disable=no-member
assert (
pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK
pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK # pylint: disable=no-member
) != 0
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK) == 0
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK) == 0 # pylint: disable=no-member
assert (pb.flags & ~ALL_SPAN_FLAGS_MASK) == 0

def test_span_flags_remote_parent_sampled(self):
Expand All @@ -547,11 +547,11 @@ def test_span_flags_remote_parent_sampled(self):
)
span = SDKSpan(name="child", context=span_context, parent=parent)
pb = _encode_span(span)
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK) == 0x01
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK) == 0x01 # pylint: disable=no-member
assert (
pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK
pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK # pylint: disable=no-member
) != 0
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK) != 0
assert (pb.flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK) != 0 # pylint: disable=no-member
assert (pb.flags & ~ALL_SPAN_FLAGS_MASK) == 0

def test_link_flags_local_and_remote(self):
Expand All @@ -565,24 +565,24 @@ def test_link_flags_local_and_remote(self):
)
pb_links = _encode_links([l1, l2])
assert (
pb_links[0].flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK
pb_links[0].flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK # pylint: disable=no-member
) == 0x01
assert (
pb_links[0].flags
& PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK
& PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK # pylint: disable=no-member
) != 0
assert (
pb_links[0].flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK
pb_links[0].flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK # pylint: disable=no-member
) == 0
assert (pb_links[0].flags & ~ALL_SPAN_FLAGS_MASK) == 0
assert (
pb_links[1].flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK
pb_links[1].flags & PB2SpanFlags.SPAN_FLAGS_TRACE_FLAGS_MASK # pylint: disable=no-member
) == 0x01
assert (
pb_links[1].flags
& PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK
& PB2SpanFlags.SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK # pylint: disable=no-member
) != 0
assert (
pb_links[1].flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK
pb_links[1].flags & PB2SpanFlags.SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK # pylint: disable=no-member
) != 0
assert (pb_links[1].flags & ~ALL_SPAN_FLAGS_MASK) == 0