feat: Use Semconv Naming For ActionPack #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligns the span name closer to the specification instead of using Ruby class/method naming syntax Fixes open-telemetry#961
arielvalentin
requested review from
a team,
ahayworth,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
MikeGoldsmith
approved these changes
Nov 6, 2024
Member
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks good to me. Added a couple of queries for commented out assertions.
| _(last_response.body).must_equal 'created new item' | ||
| _(last_response.ok?).must_equal true | ||
| _(span.name).must_equal 'ExampleController#new_item' | ||
| # _(span.name).must_equal 'GET example/new_item' |
Member
There was a problem hiding this comment.
Should these be updated or removed?
Contributor
Author
There was a problem hiding this comment.
Oh my. That definitely was a mistake on my part.
Thank you for pointing this out!
| get 'internal_server_error' | ||
|
|
||
| _(span.name).must_equal 'ExampleController#internal_server_error' | ||
| # _(span.name).must_equal 'GET example/show' |
Member
There was a problem hiding this comment.
Should these be updated or removed?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the span name closer to the specification instead of using Ruby class/method naming syntax
Fixes #961