Skip to content

fix: strict rdkafka support to v0.14 #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 7, 2025
Merged

fix: strict rdkafka support to v0.14 #1326

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
566411e
fix: strict rdkafka support to v0.14
arielvalentin Jan 7, 2025
3dd21b2
squash: fix argument error
arielvalentin Jan 7, 2025
c597ab2
squash: OMG
arielvalentin Jan 7, 2025
f5408aa
squash: skip incompatible versions
arielvalentin Jan 7, 2025
8b57d6a
squash: use compatible? predicate
arielvalentin Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions instrumentation/rdkafka/Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@
#
# SPDX-License-Identifier: Apache-2.0

appraise 'rdkafka-0.12.x' do
gem 'rdkafka', '~> 0.12.0'
end

appraise 'rdkafka-0.13.x' do
gem 'rdkafka', '~> 0.13.0'
%w[0.12.0 0.13.0 0.14.0].each do |version|
appraise "rdkafka-#{version}" do
gem 'rdkafka', "~> #{version}"
end
end

appraise 'rdkafka-latest' do
Expand Down
5 changes: 2 additions & 3 deletions instrumentation/rdkafka/lib/opentelemetry/instrumentation/rdkafka/instrumentation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@ module Instrumentation
module Rdkafka
# The Instrumentation class contains logic to detect and install the Rdkafka instrumentation
class Instrumentation < OpenTelemetry::Instrumentation::Base
MINIMUM_VERSION = Gem::Version.new('0.10.0')

compatible do
Gem::Version.new(::Rdkafka::VERSION) >= MINIMUM_VERSION
gem_version = Gem::Version.new(::Rdkafka::VERSION)
Gem::Requirement.new('>= 0.10.0', '< 0.15.0').satisfied_by?(gem_version)
end

install do |_config|
Expand Down
Loading