test: Fix Sidekiq NameError ActiveJob #1425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidekiq v7.3.9 fixed a load ordering problem where it was requiring its ActiveJob Adapter too early: sidekiq/sidekiq@886e434 Our tests relied on this load ordering bug so the suite started failing: https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/13447267345/job/37575230194 ```console /opt/hostedtoolcache/Ruby/3.4.1/x64/lib/ruby/gems/3.4.0/gems/sidekiq-7.3.9/lib/active_job/queue_adapters/sidekiq_adapter.rb:71:in '<class:SidekiqAdapter>': uninitialized constant Sidekiq::ActiveJob (NameError) class JobWrapper < Sidekiq::ActiveJob::Wrapper ``` This change borrows from Sidekiq's test suite to ensure the Rails integration is loaded: https://github.com/sidekiq/sidekiq/blob/main/test/helper.rb#L75
arielvalentin
force-pushed
the
fix-sidekiq-test
branch
from
90070b5 to
6600fbe
Compare
arielvalentin
requested review from
a team,
ahayworth,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
kaylareopelle
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidekiq v7.3.9 fixed a load ordering problem where it was requiring its ActiveJob Adapter too early:
sidekiq/sidekiq@886e434
Our tests relied on this load ordering bug so the suite started failing:
https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/13447267345/job/37575230194
This change borrows from Sidekiq's test suite to ensure the Rails integration is loaded: https://github.com/sidekiq/sidekiq/blob/main/test/helper.rb#L75