chore: Enable Gemfile Dev Deps #1426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielvalentin
force-pushed
the
enable-development-dependencies-gemfile
branch
from
48b14b6 to
c473ecc
Compare
arielvalentin
requested review from
a team,
ahayworth,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
kaylareopelle
approved these changes
Feb 26, 2025
bin/update-dependencies
Outdated
| fi | ||
|
|
||
| for gemspec in $(git ls-files \*.gemspec) | ||
| for gemspec in $(git ls-files \*Gemfile) |
Contributor
There was a problem hiding this comment.
I know we usually use this for dev dependencies, but prior to this PR, the script could also be used with general dependencies too. if this is all that needs to be changed, what do you think about updating documentation (possibly in CONTRIBUTING.md) to note how to adjust the script to update dependencies in gemspecs?
Contributor
Author
There was a problem hiding this comment.
True! I'll make sure this supports both.
Contributor
|
@arielvalentin - Thanks for the updates! Once the conflicts are resolved I'll merge this in. It doesn't look like I have the option to resolve them myself. |
arielvalentin
force-pushed
the
enable-development-dependencies-gemfile
branch
from
c3b6c2b to
6f50651
Compare
kaylareopelle
added a commit
to kaylareopelle/opentelemetry-ruby-contrib
that referenced
this pull request
Aug 18, 2025
In open-telemetry#1426 we enabled Gemfile dev dependencies.
kaylareopelle
added a commit
that referenced
this pull request
Aug 21, 2025
In #1426 we enabled Gemfile dev dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecdevelopmentdependencies