-
Notifications
You must be signed in to change notification settings - Fork 226
feat: update gem version requirement of rdkafka #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kaylareopelle
merged 13 commits into
open-telemetry:main
from
joker1007:update-rdkafka-requirement
May 1, 2025
+88
−85
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3e729f4
chore: update gem version requirement of rdkafka
joker1007 becdd91
fix: consider `each_batch` removed in rdkafka-0.20.0
joker1007 2d68893
chore: delete redundant `::`
joker1007 de95123
fix: delete `each_batch` method from targets of instrumentation
joker1007 bef1b2b
fix: fix version constraint of rdkafka
joker1007 8eb9e36
Merge branch 'main' into update-rdkafka-requirement
joker1007 3b55baa
Merge branch 'main' into update-rdkafka-requirement
kaylareopelle d4002df
Revert "fix: delete `each_batch` method from targets of instrumentation"
joker1007 558d40d
ci: update Appraisals of rdkafka to support recent versions
joker1007 48077e3
fix: loosen version constraints to support old versions
joker1007 eeec9d1
Merge branch 'main' into update-rdkafka-requirement
kaylareopelle ad9ccf6
fix: Make the unmaintained versions of rdkafka-ruby unsupported
joker1007 44c436b
Merge branch 'main' into update-rdkafka-requirement
kaylareopelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @arielvalentin means to change to
Gem::Requirement.new('>= 0.20.0').satisfied_by?(gem_version)for new instrumentation-rdkafka version