fix: add support for Sidekiq 8 #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thanks, @dmathieu! This is looking good. I have a suggestion on how to skip the Sidekiq 8 suite for Ruby 3.1.
Co-authored-by: Kayla Reopelle <[email protected]>
dmathieu
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
tt
approved these changes
Mar 14, 2025
...on/sidekiq/lib/opentelemetry/instrumentation/sidekiq/middlewares/client/tracer_middleware.rb
Outdated
Show resolved
Hide resolved
...on/sidekiq/lib/opentelemetry/instrumentation/sidekiq/middlewares/server/tracer_middleware.rb
Outdated
Show resolved
Hide resolved
…kiq/middlewares/server/tracer_middleware.rb Co-authored-by: Troels Thomsen <[email protected]>
…kiq/middlewares/client/tracer_middleware.rb Co-authored-by: Troels Thomsen <[email protected]>
arielvalentin
approved these changes
Mar 26, 2025
Contributor
arielvalentin
left a comment
arielvalentin
left a comment
There was a problem hiding this comment.
Thanks for this fix.
I think longer term we need to make some SDK changes to mitigate this. The timestamp should probably be a Ruby Time object to mitigate these kinds of weird cases that would result in overflows.
smoke
added a commit
to smoke/opentelemetry-ruby-contrib
that referenced
this pull request
Oct 6, 2025
smoke
added a commit
to smoke/opentelemetry-ruby-contrib
that referenced
this pull request
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Sidekiq 8 in the tests.
It also fixes an error where the event timestamp was provided in milliseconds, and therefore caused range errors when being converted into OTLP because the bignum was too large.