fix: Do not pollute the OpenTelemetry::Instrumentation namespace
#1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
|
|
paracycle
force-pushed
the
uk-fix-utils-classes
branch
from
4193881 to
2d23532
Compare
kaylareopelle
changed the title
OpenTelemetry::Instrumentation namespaceOpenTelemetry::Instrumentation namespace
Contributor
|
Hi @paracycle, thank you for opening this PR! Great catch. This will put Dalli in line with the other gems that have a Would you mind merging |
simi
approved these changes
Apr 29, 2025
The `dalli` instrumentation is defining a `Utils` module under the `OpenTelemetry::Instrumentation`. The `Utils` module should be an internal concern of the instrumentation library, and thus, the module should've been under the `OpenTelemetry::Instrumentation::Dalli` namespace.
paracycle
force-pushed
the
uk-fix-utils-classes
branch
from
2d23532 to
97a6fc1
Compare
Contributor
Author
Thanks for reviewing
Just rebased my commit on |
kaylareopelle
approved these changes
Apr 29, 2025
Contributor
|
The test failures seem unrelated to this PR, so I'm going to merge anyway. Thank you! I'll get a release started. |
yiyuan-he
pushed a commit
to yiyuan-he/opentelemetry-ruby-contrib
that referenced
this pull request
Apr 30, 2025
…pen-telemetry#1511) Do not pollute the `OpenTelemetry::Instrumentation` namespace The `dalli` instrumentation is defining a `Utils` module under the `OpenTelemetry::Instrumentation`. The `Utils` module should be an internal concern of the instrumentation library, and thus, the module should've been under the `OpenTelemetry::Instrumentation::Dalli` namespace.
yiyuan-he
pushed a commit
to yiyuan-he/opentelemetry-ruby-contrib
that referenced
this pull request
May 14, 2025
…pen-telemetry#1511) Do not pollute the `OpenTelemetry::Instrumentation` namespace The `dalli` instrumentation is defining a `Utils` module under the `OpenTelemetry::Instrumentation`. The `Utils` module should be an internal concern of the instrumentation library, and thus, the module should've been under the `OpenTelemetry::Instrumentation::Dalli` namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dalliinstrumentation is defining aUtilsmodule under theOpenTelemetry::Instrumentation. TheUtilsmodule should be an internal concern of the instrumentation library, and thus, the module should've been under theOpenTelemetry::Instrumentation::Dallinamespace.Also, the file was already under the
lib/opentelemetry/instrumentation/dallifolder, so theOpenTelemetry::Instrumentation::Dallinamespace is more appropriate.