fix: action_pack always assuming sdk spans #1562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlaurin
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
simi and
xuan-cao-swi
as code owners
robertlaurin
commented
Jun 16, 2025
| # If there is an exception we want to keep the original span name | ||
| # so it is easier to see where the request was routed to. | ||
| elsif request.env['action_dispatch.exception'] | ||
| span.name |
Contributor
Author
There was a problem hiding this comment.
API spans have a setter, but not a getter for name.
arielvalentin
approved these changes
Jun 16, 2025
| span = OpenTelemetry::Instrumentation::Rack.current_span | ||
| span_name = if @span_naming == :semconv | ||
| if http_route | ||
| if @span_naming == :semconv |
Contributor
There was a problem hiding this comment.
Should we skip this entire logic unless span.recording??
Contributor
Author
There was a problem hiding this comment.
Yeah, that's a good improvement to make. Pushed up that change.
fbogsany
approved these changes
Jun 16, 2025
Contributor
Technically, it is incorrect to use it for SDK spans too, other than in span processors. |
robertlaurin
force-pushed
the
fix-sdk-span-dep
branch
from
ae6bcb1 to
af5d199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
span.nameis not a method on api/non recording spans. This small refactor changes the logic around renaming to stop relying on the presence ofspan.namefor when the naming convention isclass_name.Adds a small regression test to prevent this mistake from being re-introduced.