feat: HTTPX semantic convention stability opt in #1589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
changed the title
hannahramadan
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
9 tasks
instrumentation/httpx/lib/opentelemetry/instrumentation/httpx/dup/plugin.rb
Outdated
Show resolved
Hide resolved
instrumentation/httpx/lib/opentelemetry/instrumentation/httpx/stable/plugin.rb
Outdated
Show resolved
Hide resolved
| attributes[OpenTelemetry::SemanticConventions::Trace::PEER_SERVICE] = config[:peer_service] if config[:peer_service] | ||
| attributes.merge!(OpenTelemetry::Common::HTTP::ClientContext.attributes) | ||
|
|
||
| span = tracer.start_span(verb.to_s, attributes: attributes, kind: :client, start_timestamp: start_time) |
There was a problem hiding this comment.
If you remove the .to_s in dup, it should be removed here too.
There was a problem hiding this comment.
removed in f9cbcc8
ericmustin
approved these changes
Jul 21, 2025
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to assist in the transition from the old to new HTTP semantic conventions. Per the HTTP semantic convention stability migration spec, users should be able to set the environment variable
OTEL_SEMCONV_STABILITY_OPT_INto:httpto emit stable conventions onlyhttp/dupto emit both old and the stable conventionsHTTP GETis now justGET- specThe agent is required to maintain this bridge for 6 months and may drop the environment variable in the next major version and emit only the stable HTTP and networking conventions.
This approach was approved in #1547