Skip to content

fix!: check if span has the attributes method to avoid internal error #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 16, 2025
Merged

fix!: check if span has the attributes method to avoid internal error #1645

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3fca12b
fix!: check if span has the attributes method to avoid internal error
xuan-cao-swi Aug 20, 2025
709d140
Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/a…
xuan-cao-swi Aug 21, 2025
ef4c391
Merge branch 'main' into lambda-inst-fix
kaylareopelle Aug 21, 2025
bed78cf
Merge branch 'main' into lambda-inst-fix
kaylareopelle Sep 15, 2025
4bf45dd
Merge branch 'main' into lambda-inst-fix
xuan-cao-swi Sep 15, 2025
67bc53c
add test case
xuan-cao-swi Sep 16, 2025
8033ffb
add better test case
xuan-cao-swi Sep 16, 2025
d262c30
Merge branch 'main' into lambda-inst-fix
kaylareopelle Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/wrap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def wrap_lambda(event:, context:, handler:, flush_timeout: DEFAULT_FLUSH_TIMEOUT
begin
response = yield

unless span.attributes.key?(OpenTelemetry::SemanticConventions::Trace::HTTP_STATUS_CODE)
if span.respond_to?(:attributes) && !span.attributes.key?(OpenTelemetry::SemanticConventions::Trace::HTTP_STATUS_CODE)
Copy link
Contributor

@robertlaurin robertlaurin Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can just check if the span is recording, right?

Suggested change
if span.respond_to?(:attributes) && !span.attributes.key?(OpenTelemetry::SemanticConventions::Trace::HTTP_STATUS_CODE)
if span.recording? && !span.attributes.key?(OpenTelemetry::SemanticConventions::Trace::HTTP_STATUS_CODE)

Copy link
Contributor

@robertlaurin robertlaurin Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this span attribute getting set anyways? Instrumentation should really not be making any decisions based of the contents of the spans attributes.

Copy link
Contributor Author

@xuan-cao-swi xuan-cao-swi Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws lambda instrumentation attribute is set through otel_attributes(event, context) from in_span; and then it will add the attribute HTTP_STATUS_CODE.

Instrumentation should really not be making any decisions based of the contents of the spans attributes.

This part only sets attributes like HTTP_STATUS_CODE as part of span metadata.

The issue is that if the span is not recording, it won't have the attributes method, which can raise an error. This error could overshadow the user's original Lambda function error, causing confusion.

status_code = response['statusCode'] || response[:statusCode] if response.is_a?(Hash)
span.set_attribute(OpenTelemetry::SemanticConventions::Trace::HTTP_STATUS_CODE, status_code) if status_code
end
Expand Down