docs: typo in Rack::Instrumentation usage example of middleware_args #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juanmcuello
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
The committers listed above are authorized under a signed CLA. |
Juanmcuello
force-pushed
the
fix-typo-rack-example
branch
from
596e862 to
0120129
Compare
Juanmcuello
force-pushed
the
fix-typo-rack-example
branch
from
0120129 to
40f23b6
Compare
ericmustin
approved these changes
Aug 30, 2025
Contributor
ericmustin
left a comment
ericmustin
left a comment
There was a problem hiding this comment.
Good catch! Thank you for the pr
arielvalentin
approved these changes
Aug 31, 2025
hannahramadan
approved these changes
Sep 2, 2025
arielvalentin
changed the title
Contributor
|
I've reclassified this as a docs change as opposed to a fix which implies there is a bug in the code. |
kaylareopelle
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.