docs: Enhance README #1711
Merged
docs: Enhance README #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-corneanu
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
kaylareopelle
requested changes
Oct 1, 2025
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thank you for this PR! The text looks good. I have some feedback on the placement.
Lines 44-50 should be above the configuration section. They go along with the earlier code snippet related to installing a single instrumentation.
Also, what do you think about adding a Configuration/Configuration Options heading, or something to that effect? It would keep the document's structure more consistent.
kaylareopelle
changed the title
dan-corneanu
force-pushed
the
update-active-job-instrumentation-readme
branch
from
cb5f73c to
1e15190
Compare
Document configuration options for ActiveJob instrumentation.
dan-corneanu
force-pushed
the
update-active-job-instrumentation-readme
branch
from
355def8 to
2d38afc
Compare
dan-corneanu
changed the title
arielvalentin
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance README with additional configuration options for ActiveJob instrumentation.