feat: add example.id attribute to RSpec instrumentation #1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
americodls
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
Record RSpec's example.id as a span attribute to provide unique identification for each test example. This is particularly valuable when examples are created dynamically (e.g., within loops), where multiple examples share the same file location but have distinct IDs.
americodls
force-pushed
the
ad/add-example-id-attribute
branch
3 times, most recently
from
b2abd9b to
966e985
Compare
americodls
added a commit
to intercom/opentelemetry-ruby-contrib
that referenced
this pull request
Oct 2, 2025
This PR adds RSpec's `example.id` as a span attribute to provide unique identification for each test example. The existing `rspec.example.location` attribute cannot uniquely identify dynamically generated examples (e.g., examples created within loops or using data tables) because multiple examples share the same source file location. RSpec's `example.id` provides a stable, unique identifier across test runs even for these dynamic cases. Example format: `./spec/foo_spec.rb[1:2:3]` This enables better correlation and tracking of individual test executions in observability platforms. --- Upstream PR: open-telemetry#1713
kaylareopelle
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Thanks for your contribution, @americodls. This makes sense to me. I'll leave it open for a few more days to see if any of the other approvers/maintainers have feedback.
americodls
added a commit
to intercom/opentelemetry-ruby-contrib
that referenced
this pull request
Oct 8, 2025
This PR adds RSpec's `example.id` as a span attribute to provide unique identification for each test example. The existing `rspec.example.location` attribute cannot uniquely identify dynamically generated examples (e.g., examples created within loops or using data tables) because multiple examples share the same source file location. RSpec's `example.id` provides a stable, unique identifier across test runs even for these dynamic cases. Example format: `./spec/foo_spec.rb[1:2:3]` This enables better correlation and tracking of individual test executions in observability platforms. --- Upstream PR: open-telemetry#1713
|
@chrisholmes may I please have a review here? |
americodls
added a commit
to intercom/opentelemetry-ruby-contrib
that referenced
this pull request
Oct 12, 2025
This PR adds RSpec's `example.id` as a span attribute to provide unique identification for each test example. The existing `rspec.example.location` attribute cannot uniquely identify dynamically generated examples (e.g., examples created within loops or using data tables) because multiple examples share the same source file location. RSpec's `example.id` provides a stable, unique identifier across test runs even for these dynamic cases. Example format: `./spec/foo_spec.rb[1:2:3]` This enables better correlation and tracking of individual test executions in observability platforms. --- Upstream PR: open-telemetry#1713
americodls
added a commit
to intercom/opentelemetry-ruby-contrib
that referenced
this pull request
Oct 14, 2025
This PR adds RSpec's `example.id` as a span attribute to provide unique identification for each test example. The existing `rspec.example.location` attribute cannot uniquely identify dynamically generated examples (e.g., examples created within loops or using data tables) because multiple examples share the same source file location. RSpec's `example.id` provides a stable, unique identifier across test runs even for these dynamic cases. Example format: `./spec/foo_spec.rb[1:2:3]` This enables better correlation and tracking of individual test executions in observability platforms. --- Upstream PR: open-telemetry#1713
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RSpec's
example.idas a span attribute to provide unique identification for each test example.The existing
rspec.example.locationattribute cannot uniquely identify dynamically generated examples (e.g., examples created within loops or using data tables) because multiple examples share the same source file location. RSpec'sexample.idprovides a stable, unique identifier across test runs even for these dynamic cases.Example format:
./spec/foo_spec.rb[1:2:3]This enables better correlation and tracking of individual test executions in observability platforms.