Skip to content

feat: Refactor SQL processor file structure for clarity #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 28, 2025
Merged

feat: Refactor SQL processor file structure for clarity #1731

merged 6 commits into from
Oct 28, 2025

Conversation

@hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented Oct 9, 2025

Refactored the SQL processing module structure to improve organization and prepare for future functionality expansion.

  • SqlProcessor is more descriptive than SqlObfuscation for a module that will handle multiple SQL operations
  • Ready to add query summarization and other future SQL processing features
  • Separates public API from implementation details
  • Is a nice looking method call: OpenTelemetry::Helpers::SqlProcessor.obfuscate_sql

@hannahramadan hannahramadan changed the title fix: Refactor SQL processor file structure for clarity feat: Refactor SQL processor file structure for clarity Oct 9, 2025
@kaylareopelle kaylareopelle merged commit 61451b5 into open-telemetry:main Oct 28, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arielvalentin arielvalentin arielvalentin approved these changes

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

@simi simi Awaiting requested review from simi simi is a code owner

@xuan-cao-swi xuan-cao-swi Awaiting requested review from xuan-cao-swi xuan-cao-swi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hannahramadan @arielvalentin @kaylareopelle