Skip to content

fix: does not trace resolve type unless enable #1759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 26, 2025
Merged

fix: does not trace resolve type unless enable #1759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e258c5
fix: does not trace resolve type unless enable
xuanduc987 Oct 24, 2025
e3763d2
chore: address robocop check
xuanduc987 Oct 24, 2025
0dd2367
Merge branch 'main' into push-yssyoqxqtquk
arielvalentin Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/tracers/graphql_trace.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,16 @@ def authorized_lazy(query:, type:, object:, &)

def resolve_type(query:, type:, object:, &)
platform_key = @_otel_resolve_type_key_cache[type]
return super unless platform_key

attributes = @_otel_type_attrs_cache[type]
tracer.in_span(platform_key, attributes: attributes) { super }
end

def resolve_type_lazy(query:, type:, object:, &)
platform_key = @_otel_resolve_type_key_cache[type]
return super unless platform_key

attributes = @_otel_lazy_type_attrs_cache[type]
tracer.in_span(platform_key, attributes: attributes) { super }
end
Expand Down
22 changes: 22 additions & 0 deletions instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_trace_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,28 @@
end
end

describe 'when platform_resolve_type is disabled' do
let(:config) { { enable_platform_resolve_type: false } }

it 'does not trace .resolve_type' do
skip unless supports_authorized_and_resolved_types?
SomeGraphQLAppSchema.execute('{ vehicle { __typename } }')

parent = spans.find { |s| s.name == 'graphql.execute_query' }
span = spans.find { |s| s.parent_span_id == parent.span_id }
_(span).must_be_nil
end

it 'does not traces .resolve_type_lazy' do
skip unless supports_authorized_and_resolved_types?
SomeGraphQLAppSchema.execute('{ vehicle { __typename } }', context: { lazy_type_resolve: true })

parent = spans.find { |s| s.name == 'graphql.execute_query_lazy' }
span = spans.find { |s| s.parent_span_id == parent.span_id }
_(span).must_be_nil
end
end

describe 'when platform_resolve_type is enabled with legacy naming' do
let(:config) { { enable_platform_resolve_type: true, legacy_platform_span_names: true } }

Expand Down