feat: HTTP Client Semconv Span Naming #1788
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It corrects the span name for the old semantic conventions where the name should be set to the HTTP Method or the literal
HTTPas well as adds theurl.templateto the name when using stable conventions.More explicitly stated, when using
oldconventions the span name will be one of the known HTTP method (GET,PUT,POST,PATCH,DELETE...) orHTTPif the method is non-standard.When using
duporstableconventions the name may contain aurl.templatevalue if it is known at the time or the request. Users may provide aurl.templatevia theClientContextattributes.Some concessions:
See #1779
Notice to reviewers
This is a follow up to #1781
The relevant commit in this PR is
49c6dc0