Skip to content

chore: Update instrumentation generator #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −2
Open

chore: Update instrumentation generator #1792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .instrumentation_generator/instrumentation_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,16 @@ def add_to_releases
insert_into_file('.toys/.data/releases.yml', release_details, after: "gems:\n")
end

def add_to_component_owners
release_details = <<-HEREDOC
instrumentation/#{instrumentation_gem_name}:
# TODO: Add your GitHub username
# - (your github username)
HEREDOC

insert_into_file('.github/component_owners.yml', release_details, after: "components:\n")
end

def add_to_instrumentation_all
instrumentation_all_path = 'instrumentation/all'
gemfile_text = "\ngem '#{instrumentation_gem_name}', path: '../#{instrumentation_name}'"
Expand Down
2 changes: 1 addition & 1 deletion .instrumentation_generator/templates/gemspec.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
Dir.glob('*.md') +
['LICENSE', '.yardopts']
spec.require_paths = ['lib']
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
spec.required_ruby_version = ">= 3.2"

spec.add_dependency 'opentelemetry-instrumentation-base', '~> <%= instrumentation_base_version %>'

Expand Down
2 changes: 1 addition & 1 deletion bin/instrumentation_generator
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ puts <<-EOF

🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

WARNING: Your gem will *NOT* be tested until you add it to the CI workflows in `.github/workflows/ci.yml`!!
WARNING: Your gem will *NOT* be tested until you add it to the CI workflows in `.github/workflows/ci-contrib.yml`!! We use path filters to control what tests are run, so take a look at the available workflows to find the best fit.

🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨

Expand Down