Skip to content

test(rails): bump minitest to v6, remove test_unit/railtie from dummy test app#2061

Open
thompson-tomo wants to merge 3 commits intoopen-telemetry:mainfrom
thompson-tomo:patch-11
Open

test(rails): bump minitest to v6, remove test_unit/railtie from dummy test app#2061
thompson-tomo wants to merge 3 commits intoopen-telemetry:mainfrom
thompson-tomo:patch-11

Conversation

@thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Mar 8, 2026

rails/test_unit/railtie is causing test grief. (See also: rails/rails#56202)

It provides rake test task integration, test generators, and app.config options for generators. We don't need any of these convenience features in our dummy app.

@robbkidd robbkidd changed the title test: stop requiring railtie dep(rails): bump minitest to v6, remove test_unit/railtie from dummy test app Mar 19, 2026
Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

I took the liberty of wordsmithing the PR subject and description. If I got something wrong there, please re-edit!

@robbkidd robbkidd changed the title dep(rails): bump minitest to v6, remove test_unit/railtie from dummy test app test(rails): bump minitest to v6, remove test_unit/railtie from dummy test app Mar 19, 2026
@robbkidd
Copy link
Member

OK, Conventional Commits. Fine. "test" it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file instrumentation-rails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants