fix: handle float value in NumberDataPoint #1767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently possible to have a `Counter` with a `Float` value, but this fails to export because the `NumberDataPoint` is always assumed to be an `Integer` for the purposes of ProtoBuf encoding. The `.proto` for a `NumberDataPoint` allows for a float value in the `as_double` key, so there should be no reason that we should not be able to support `Float` `Counter`s. This commit adds support for `Float` values in `NumberDataPoint`, which in turn adds support for `Float` `Counter`s. I also updated the documentation in the structs for both `NumberDataPoint.value` and `HistogramDataPoint.sum` to match the expected type based on the `.proto`. Adds a test to confirm that the metrics_exporter handles both `Integer` and `Float` values for a `NumberDataPoint`.
percygrunwald
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
arielvalentin
changed the title
kaylareopelle
approved these changes
Nov 22, 2024
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thank you, @percygrunwald! This is a great catch.
metrics_sdk/lib/opentelemetry/sdk/metrics/aggregation/histogram_data_point.rb
Outdated
Show resolved
Hide resolved
…m_data_point.rb Co-authored-by: Kayla Reopelle <[email protected]>
xuan-cao-swi
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently possible to have a
Counterwith aFloatvalue, but this fails to export because theNumberDataPointis always assumed to be anIntegerfor the purposes of ProtoBuf encoding. The.protofor aNumberDataPointallows for a float value in theas_doublekey, so there should be no reason that we should not be able to supportFloatCounters.This commit adds support for
Floatvalues inNumberDataPoint, which in turn adds support forFloatCounters. I also updated the documentation in the structs for bothNumberDataPoint.valueandHistogramDataPoint.sumto match the expected type based on the.proto.Adds a test to confirm that the metrics_exporter handles both
IntegerandFloatvalues for aNumberDataPoint.Noting the error message output without this change: