-
Notifications
You must be signed in to change notification settings - Fork 278
feat!: add kind enum type for aggregation_temporality that only allow two types #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
@xuan-cao-swi - What do you think about changing the conventional commit type to |
kaylareopelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this back to my attention!
|
|
||
| def initialize(aggregation_temporality: :delta) | ||
| @aggregation_temporality = aggregation_temporality | ||
| @aggregation_temporality = aggregation_temporality == :cumulative ? AggregationTemporality.cumulative : AggregationTemporality.delta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a future PR, it might be worth reducing some duplication by defining a method within AggregationTemporality that can perform this logic for all applicable aggregations.
My bad, forgot this question was out there before I merged, but let me know what you think and I can make adjustments during the release. |
Relates to #1742, #1555
Description