-
Notifications
You must be signed in to change notification settings - Fork 278
fix: update out-of-date google-protobuf-any #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do we need to update the min version of the protobuf dependencies for the gems too? |
I'm not very familiar with protobuf but I can share what I found: I don't think we need to update protobuf dependencies ( By looking at the well_known_types.rb, it seems like we can access The |
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
kaylareopelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @xuan-cao-swi, coming back to this one. I think this is a good change. Would you mind adding a regression test?
|
Hi @kaylareopelle, I think this test cover the case; but I still add one test case that parse the request from raw byte. I still couldn't figure out why this type_name is missing, so I asked on protobuf repo. FYI, our current test case use protobuf 3.25, but latest one is 4.30. |
Thank you and thanks for raising the issue! I think it would be helpful to start testing using newer versions of protobuf. I created a PR to do this, but it fell down in priority and I couldn't see it through to the end. Feel free to open one if you have the bandwidth! |
Closes: #1814
This issue won't cause any major breakdown since it's only for logging the error message.
If the change is valid, then it needs to be updated for all exporters.