fix: add test case for metric_store and metric_view #1894
+658
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuan-cao-swi
changed the title
xuan-cao-swi
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
Comment on lines
74
to
76
| def now_in_nano | ||
| (Time.now.to_r * 1_000_000_000).to_i | ||
| end |
There was a problem hiding this comment.
There's a helper for this now in the common gem:
opentelemetry-ruby/common/lib/opentelemetry/common/utilities.rb
Lines 45 to 51 in 3d82438
metrics_sdk/lib/opentelemetry/sdk/metrics/state/asynchronous_metric_stream.rb
Show resolved
Hide resolved
|
|
||
| metric_data = nil | ||
| threads = Array.new(5) do | ||
| # Thread.new { thread_stream.invoke_callback(timeout, attributes) } |
There was a problem hiding this comment.
Do we still need this?
Comment on lines
226
to
241
| describe '#now_in_nano' do | ||
| it 'returns current time in nanoseconds with increasing values' do | ||
| nano_time = async_metric_stream.now_in_nano | ||
| _(nano_time).must_be_instance_of(Integer) | ||
| _(nano_time).must_be :>, 0 | ||
|
|
||
| # Should be a reasonable timestamp (not too old, not in future) | ||
| current_time_nano = (Time.now.to_r * 1_000_000_000).to_i | ||
| _(nano_time).must_be_close_to(current_time_nano, 1_000_000_000) # Within 1 second | ||
|
|
||
| # Test successive calls return increasing values | ||
| sleep(0.001) # Small delay | ||
| time2 = async_metric_stream.now_in_nano | ||
| _(time2).must_be :>, nano_time | ||
| end | ||
| end |
There was a problem hiding this comment.
If you swap to using the utils method, can take these out.
metrics_sdk/lib/opentelemetry/sdk/metrics/state/asynchronous_metric_stream.rb
Show resolved
Hide resolved
Comment on lines
136
to
137
| # this test case is unstable as it involve thread in minitest | ||
| skip if snapshot.size != 10 |
There was a problem hiding this comment.
How often do you think this is skipped?
There was a problem hiding this comment.
Removed these unstable thread-related test for now.
xuan-cao-swi
changed the title
kaylareopelle
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1890
Description
Found a couple of issues while developing the test case:
Timeout.timeoutwith thread for executing the callback.Each metric_stream should be bound to its own instrument. While most functionality is tested through instruments, here we focus on fundamental correctness, which will be important when views and exemplars are updated.