Skip to content

feat: add logging about export status to Metrics #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: add logging about export status to Metrics #1937

wants to merge 8 commits into from

Conversation

wsmoak
Copy link

@wsmoak wsmoak commented Oct 12, 2025 •
edited
Loading

Adds some debug log output for successfully exporting metrics, and additional error logging. Implementation is borrowed from the Batch Log Record Processor.

Does not include a count. Eventually that can be handled with the otel.sdk.exporter.metric_data_point.exported internal metric. See https://opentelemetry.io/docs/specs/semconv/otel/sdk-metrics/

Fixes: #1888

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 12, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@wsmoak wsmoak marked this pull request as ready for review October 12, 2025 21:45
@wsmoak
Copy link
Author

wsmoak commented Oct 12, 2025

Tested locally, example log output:

D, [2025-10-12T12:51:41.996103 #84725] DEBUG -- : Successfully exported 1 log records
D, [2025-10-12T12:51:43.004206 #84725] DEBUG -- : Successfully exported 4 log records
D, [2025-10-12T12:51:48.115910 #84725] DEBUG -- : Successfully exported metrics

and with the otel collector shut down:

W, [2025-10-12T12:51:21.864191 #84645]  WARN -- : SystemCallError in MetricsExporter#send_bytes
E, [2025-10-12T12:51:21.864444 #84645] ERROR -- : OpenTelemetry error: Unable to export metrics
E, [2025-10-12T12:51:21.864550 #84645] ERROR -- : Result code: 1

kaylareopelle
kaylareopelle approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add logging about export status to Metrics

2 participants

@wsmoak @kaylareopelle