Add retry and status code handling tests to trace exporter #1960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zFlux
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
|
|
Author
|
Should I move the retry and backoff logic into |
zFlux
force-pushed
the
chore/retry-behaviour-tests
branch
from
4adff67 to
b079871
Compare
Author
|
I'm going to close this and tackle something flagged with "good first issue". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests verifying that the OTLP HTTP trace exporter retries on 5xx and 429 responses, and does not retry on client errors (4xx). Confirms exponential backoff and export result statuses are mapped correctly according to the spec.
Adding a few tests at a time to ultimately fully harden otlp-http, otlp-grpc, and otlp-common
Refs: #1667