Skip to content

Handle HTTP 2XX responses as successful in OTLP exporters #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivekmiyani wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −4
Open

Handle HTTP 2XX responses as successful in OTLP exporters #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5369cf9
Change response check from HTTPOK to HTTPSuccess
vivekmiyani Feb 12, 2026
1319675
Trigger build
vivekmiyani Feb 12, 2026
b719598
Trigger build
vivekmiyani Feb 12, 2026
65a97df
Change response check from HTTPOK to HTTPSuccess
vivekmiyani Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exporter/otlp-http/lib/opentelemetry/exporter/otlp/http/trace_exporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def send_bytes(bytes, timeout:) # rubocop:disable Metrics/MethodLength
response = measure_request_duration { @http.request(request) }

case response
when Net::HTTPOK
when Net::HTTPSuccess
response.body # Read and discard body
SUCCESS
when Net::HTTPServiceUnavailable, Net::HTTPTooManyRequests
Expand Down
2 changes: 1 addition & 1 deletion exporter/otlp-logs/lib/opentelemetry/exporter/otlp/logs/logs_exporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def send_bytes(bytes, timeout:) # rubocop:disable Metrics/CyclomaticComplexity,
response = @http.request(request)

case response
when Net::HTTPOK
when Net::HTTPSuccess
response.body # Read and discard body
SUCCESS
when Net::HTTPServiceUnavailable, Net::HTTPTooManyRequests
Expand Down
2 changes: 1 addition & 1 deletion exporter/otlp-metrics/lib/opentelemetry/exporter/otlp/metrics/metrics_exporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def send_bytes(bytes, timeout:)
@http.start unless @http.started?
response = @http.request(request)
case response
when Net::HTTPOK
when Net::HTTPSuccess
response.body # Read and discard body
SUCCESS
when Net::HTTPServiceUnavailable, Net::HTTPTooManyRequests
Expand Down
2 changes: 1 addition & 1 deletion exporter/otlp/lib/opentelemetry/exporter/otlp/exporter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def send_bytes(bytes, timeout:) # rubocop:disable Metrics/CyclomaticComplexity,
response = measure_request_duration { @http.request(request) }

case response
when Net::HTTPOK
when Net::HTTPSuccess
response.body # Read and discard body
SUCCESS
when Net::HTTPServiceUnavailable, Net::HTTPTooManyRequests
Expand Down
Loading